[Bug 956134] Review Request: mnmlicons-fonts - Perkins Less Web Framework webfonts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=956134

Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #11 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Hi Alec,

[asinha@localhost  SRPMS]$ rpmlint ../SPECS/mnmlicons-fonts.spec
./mnmlicons-fonts-1.1-1.fc18.src.rpm
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
../SPECS/mnmlicons-fonts.spec: E: specfile-error warning: bogus date in
%changelog: Wed May 19 2013 Alec Leamas <leamas@xxxxxxxxxxx> - 1.1-1
../SPECS/mnmlicons-fonts.spec: E: specfile-error warning: bogus date in
%changelog: Tue Apr 24 2013 Alec Leamas <leamas@xxxxxxxxxxx> - 1.1-1
mnmlicons-fonts.src: W: spelling-error Summary(en_US) webfonts -> web fonts,
web-fonts, webfoot
mnmlicons-fonts.src: E: specfile-error warning: bogus date in %changelog: Wed
May 19 2013 Alec Leamas <leamas@xxxxxxxxxxx> - 1.1-1
mnmlicons-fonts.src: E: specfile-error warning: bogus date in %changelog: Tue
Apr 24 2013 Alec Leamas <leamas@xxxxxxxxxxx> - 1.1-1
mnmlicons-fonts.noarch: W: spelling-error Summary(en_US) webfonts -> web fonts,
web-fonts, webfoot
mnmlicons-fonts.src: W: spelling-error Summary(en_US) webfonts -> web fonts,
web-fonts, webfoot
mnmlicons-fonts.src: E: specfile-error warning: bogus date in %changelog: Wed
May 19 2013 Alec Leamas <leamas@xxxxxxxxxxx> - 1.1-1
mnmlicons-fonts.src: E: specfile-error warning: bogus date in %changelog: Tue
Apr 24 2013 Alec Leamas <leamas@xxxxxxxxxxx> - 1.1-1
3 packages and 1 specfiles checked; 6 errors, 3 warnings.
[asinha@localhost  SRPMS]$

The package looks good. A few things you could correct before committing to SCM
though:

1. The spelling errors (optional)
2. The changelog entries (MUST): I think you mean June instead of May in the
latest entry ;). Not sure about the April one (it was a Wednesday). Please
rectify this before you commit. 

*** APPROVED ***

Thanks,
Warm regards,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=diFastt9Yz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]