[Bug 974714] Review Request: thermal_daemon - A close loop thermal monitoring and control daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=974714

--- Comment #8 from Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> ---
Updated:
http://spandruvada.fedorapeople.org/thermal_daemon.spec
http://spandruvada.fedorapeople.org/thermal_daemon-1.02-2.fc19.src.rpm

==============
diff --git a/rpms/thermal_daemon.spec b/rpms/thermal_daemon.spec
index f81a1b7..a55f2d5 100644
--- a/rpms/thermal_daemon.spec
+++ b/rpms/thermal_daemon.spec
@@ -1,26 +1,30 @@
 Name:           thermal_daemon
 Version:        1.02
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        The "Linux Thermal Daemon" program from 01.org

 License:        GPLv2+
-URL:            http://spandruvada.fedorapeople.org/
-Source0:        http://spandruvada.fedorapeople.org/%{name}-%{version}.tar.gz
+URL:            https://github.com/01org/thermal_daemon
+%global commit  78b9dd1343bf7350740eb76e3bf87dc207078d9d
+%global shortcommit %(c=%{commit}; echo ${c:0:7})
+Source0:       
https://github.com/01org/thermal_daemon/archive/%{commit}/%{name}-v%{version}.tar.gz

+BuildRequires:  automake
+BuildRequires:  autoconf
 BuildRequires:  glib-devel
 BuildRequires:  dbus-glib-devel
 BuildRequires:  libxml2-devel
-BuildRequires:  automake
-BuildRequires:  autoconf
-BuildRequires:  gcc-c++
+BuildRequires:  systemd
 Requires:       libxml2
+Requires(post): systemd-units
+Requires(preun): systemd-units
+Requires(postun): systemd-units

 %description
 Thermal Daemon monitors and controls platform temperature.

 %prep
-%setup -q
-
+%setup -qn %{name}-%{version}

 %build
 autoreconf -f -i
@@ -32,9 +36,16 @@ make %{?_smp_mflags}
 rm -rf $RPM_BUILD_ROOT
 %make_install DESTDIR=$RPM_BUILD_ROOT

+%post
+%systemd_post thermald.service
+
+%preun
+%systemd_preun thermald.service
+
+%postun
+%systemd_postun_with_restart thermald.service 

 %files
-%defattr(-,root,root)
 %{_bindir}/thermald
 %config(noreplace)
%{_sysconfdir}/dbus-1/system.d/org.freedesktop.thermald.conf 
 %{_datadir}/dbus-1/system-services/org.freedesktop.thermald.service
@@ -45,6 +56,7 @@ rm -rf $RPM_BUILD_ROOT
 %{_unitdir}/thermald.service

 %changelog
-* Wed May 8 2013 Base version 1.0-1
-- Base version
-- updated to vesrion 1.02
+* Tue Jun 18 2013 Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
1.02-2
+- Update spec file after first review
+* Fri Jun 14 2013 Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
1.02-1
+- Initial package

=============

Question: Is "Documentation=" field in the thermald.service is mandatory?

I hope this is better than the previous.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AGU0nxswVS&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]