Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-daap - A DAAP client implemented in Python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215659 matthias@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From matthias@xxxxxxxxxxxx 2007-03-13 06:07 EST ------- Great! Tom Insam the author) has been really receptive to the licensing concerns, which should indeed be fixed now. Now that things are clear, you could remove the "See http://jerakeen.org/code/pythondaap/#comment_643"; lines above the "License:". Nitpicks : - Remove the comments above the License line of the spec. - Add a %changelog entry for 0.7-1. - I'd put "examples/" instead of "examples" for %doc to show it's a directory. - You might want to include the PKG-INFO in %doc now that it's correct. Formal review : This is a quite trivial python package, which contains all what a python package should. It's not noarch because of the included md5 module, the LGPL license is correct and rpmlint is silent on the resulting packages... APPROVED. Feel free to "fix" any of the nitpicks from above, though ;-) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review