https://bugzilla.redhat.com/show_bug.cgi?id=974145 --- Comment #3 from Björn Esser <bjoern.esser@xxxxxxxxx> --- Created attachment 761959 --> https://bugzilla.redhat.com/attachment.cgi?id=761959&action=edit improvements for spec-file Hi Don! Just took a deeper look inside spec-file: * arch-conditionals on BRs: %ifnarch s390 s390x BuildRequires: libusbx-devel %endif ---> There's a discussion around on f-packaging ml. [1] You should possibly track where it'll lead to and act on this accordingly. Some changes I'd propose (as in attached patch): -Source: http://www.kernel.org/pub/linux/bluetooth/bluez-%{version}.tar.xz +Source0: http://www.kernel.org/pub/linux/bluetooth/bluez-%{version}.tar.xz Just cosmetic... -BuildRequires: git -BuildRequires: flex -BuildRequires: dbus-devel >= 0.90 -BuildRequires: libusb-devel, glib2-devel +BuildRequires: git flex dbus-devel +BuildRequires: libusb-devel glib2-devel reduced lines, dbus-devel has more recent ver in F17+, so no need for explicit min-version. -BuildRequires: libtool autoconf automake +BuildRequires: libtool autotools are pulled on libtool requires. -Requires: bluez5-libs = %{version}-%{release} +Requires: bluez5-libs%{?_isa} = %{version}-%{release} requires should be arched, when package is arched as well. -Requires: dbus >= 0.60 dbus is added from autorequires -Requires: hwdata >= 0.215 +Requires: hwdata hwdata has more recent ver in F17+, so no need for explicit min-version. -Obsoletes: bluez ... +Obsoletes: bluez <= 4.94-4 ... reduce rpmlint complains... -Requires: hwdata >= 0.215 -Requires(preun): /bin/systemctl -Requires(post): /bin/systemctl +# conditional and %%else and be safely removed, if not intended for < F18 +%if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 +%{systemd_requires} +%else +Requires(post): systemd-units +Requires(preun): systemd-units +Requires(postun): systemd-units +%endif +# conditional and %%else and be safely removed, if not intended for < F18 +%if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 +%post +%systemd_post bluetooth.service + +%preun +%systemd_preun bluetooth.service + +%postun +%systemd_postun_with_restart bluetooth.service +%else There are special systemd-macros avail on F18+ - - hcitool ... + - hcitool ... mixed use of spaces and tabs... -make V=1 +make V=1 %{?_smp_mflags} enable parallel build -make install DESTDIR=$RPM_BUILD_ROOT +%make_install exchanged with macro, not mandatory /sbin/ldconfig -n %{buildroot}%{_libdir} What is this used for? -%triggerun -- bluez < 4.94-4 -/bin/systemctl --no-reload enable bluetooth.service >/dev/null 2>&1 || : +%triggerun -- bluez <= 4.94-4 +if /sbin/chkconfig --level 5 bluetooth ; then + /bin/systemctl --no-reload enable bluetooth.service >/dev/null 2>&1 || : +fi + +%post libs -p /sbin/ldconfig respect admin's sysconfig on upgrade-path. only enable service by default, if was so before. generally I made some simplifications in spec, too, but don't want to comment here, since will spam the list with not really useful comments... [1] https://lists.fedoraproject.org/pipermail/packaging/2013-June/009206.html If you want, I can take full review. Cheers, Björn -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UAuTbNmzmJ&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review