[Bug 956304] Review Request: fts - File Transfer Service V3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=956304

--- Comment #9 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Please record the changes you make between each update you post here in the
%changelog section of the package.

I've also just noticed that the code is built with non-standard CFLAGS. -O3
overrides -O2. I think you should use

-D CMAKE_BUILD_TYPE=RelWithDebInfo instead of Release

There's no need to call /sbin/ldconfig in any %post/%postun scriptlets except
for -libs subpackage.

%defattr(-,root,root,-) is only necessary for EPEL5 packages. It's best to add
it in el5 branch only and keep the main spec file clutter-free.

The same goes for %clean section and rm -rf %{buildroot} at the beginning of
%install.

Likewise, BuildRoot: tag is not necessary (only on EPEL5).

Similarly, per https://fedoraproject.org/wiki/Packaging:Python , defining
%python_sitelib and %python_sitearch is necessary only on EPEL5. Moreover,
you're not using %python_sitelib anywhere in the spec.

You can drop %attr(0755,root,root) and %attr(0644,root,root) from -server
subpackage files unless the installed files have different access rights.

%files python
%defattr(-,root,root,-)
%dir %attr(0755,fts3,root) %{python_sitearch}/fts

Please explain the need for python-C glue libraries to be owned by non-root
user.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bWUV5xEHx5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]