https://bugzilla.redhat.com/show_bug.cgi?id=895592 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cickumqt@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Hmm...No javascript packaging guideline now, only a draft. >From fedora-review seems OK, but somethings maybe you should fix: 1) I found that mixture of tab and space in License and Source0 tag. 2) This library has its GitHub page, and the author has tagged the 3.0.83 version. https://github.com/alexgorbatchev/SyntaxHighlighter/tags 3) Is this spec for EL only? I've seen many obsoleted lines and buildroot tag. 4) A little more blanks between sections. Not mandatory. 5) License: MIT or GPLv2. Why not "and"? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U1CTau0QtK&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review