[Bug 927470] Review Request: python-genmsg - Python library for generating ROS message and service data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=927470

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
(In reply to Rich Mattes from comment #0)
> Not sure if the gentools.py file needs the /usr/bin/env, I'll investigate.

I'm quite sure no file in %{python_sitelib} needs a shebang and/or to be
executable.

Just a few more comments:

The initial cleaning of buildroot in %install is obsolete, please drop it.

python-setuptools-devel is a virtual provide of python-setuptools, you might
replace it by the latter.

The warning about a devel file in a non-devel package should be addressed. I
don't know how to handle pkgconfig files in Python packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hlc4C3iWBD&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]