https://bugzilla.redhat.com/show_bug.cgi?id=972237 --- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> --- > - %defattr is not needed True, and it isn't needed for EL5 anymore either, because RPM is new enough. It can be dropped from the spec file. > %{_docdir}/vcsh/README.md > %doc LICENSE CONTRIBUTORS changelog This is somewhat unfortunate, because it creates two different doc dirs and an additional "unowned" directory: $ rpmls -p vcsh-1.3-1.fc19.noarch.rpm|grep doc drwxr-xr-x /usr/share/doc/vcsh-1.3 -rw-r--r-- /usr/share/doc/vcsh-1.3/CONTRIBUTORS -rw-r--r-- /usr/share/doc/vcsh-1.3/LICENSE -rw-r--r-- /usr/share/doc/vcsh-1.3/changelog -rw-r--r-- /usr/share/doc/vcsh/README.md -rw-r--r-- /usr/share/doc/vcsh/hooks => /usr/share/doc/vcsh is not included. Even if it may sound pedantic, it would look better, if all doc files were put into the same dir. https://fedoraproject.org/wiki/Packaging:UnownedDirectories https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership > %{_datadir}/zsh A comment in the spec file would be very good here, because this line includes directories, which belong into the zsh package. That's based on the following guideline: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function A more readable notation for inclusion of a full directory tree uses adds a trailing slash, btw: %{_datadir}/zsh/ > /usr/share/zsh/site-functions/vendor-completions/_vcsh This is the same file as /usr/share/zsh/site-functions/_vcsh and no other package owns that directory already, so this may need a closer look during review. $ repoquery --whatprovides /usr/share/zsh/site-functions/vendor-completions $ > install -D -m 0644 _vcsh %{buildroot}%{_datadir}/zsh/site-functions/_vcsh https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps > mv %{buildroot}%{_datadir}/zsh/vendor-completions > %{buildroot}%{_datadir}/zsh/site-functions Since spec files are scripts, preferably one would comment on why this installed directory is moved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Vd86lfVKOo&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review