[Bug 657071] Review Request: fuse-ext2 - Ext2/3/4 file-system support for FUSE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=657071

--- Comment #9 from Jason Tibbitts <tibbs@xxxxxxxxxxx> ---
I tried to learn a bit about fuse so that I could try and get this reviewed. 
However, while looking at licenses I came across one issue.  You mention that
there is no bundled code used in this package, but could you comment on
ext2-fileio.c?  This seems to be lifted from a some version of e2fsprogs (from
lib/ext2fs/fileio.c) but it has a different license (LGPL in the e2fsprogs, GPL
in fuse-ext2) and there are various differences in the file.  I'm not at all
sure that usage is acceptable (without getting an exception from FPC).

Some additional observations:

%defattr should be removed; no release of Fedora or EPEL requires it.
You can move a bunch of other cruft from the spec if you don't intend to
support EPEL (%clean, BuildRoot definition, cleaning of buildroot as the first
line of %install).

Otherwise I think this is fine, but the bundling issue is problematic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XD5cUs60qa&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]