[Bug 950171] Review Request: librecad - Computer Assisted Design (CAD) Application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=950171

Björn Esser <bjoern.esser@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bjoern.esser@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |bjoern.esser@xxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #3 from Björn Esser <bjoern.esser@xxxxxxxxx> ---
Hello Tom!

Some issues here:

 * License-tag misses some licenses:

   ---> s'!License:.*!& and MIT and X11!'

        (need to do a more intensive check, although)

 * build.log shows there might be missing BRs:

        Project MESSAGE: muParser was not found, please install muParser!
        Project MESSAGE: Using muParser libraries in .
        (shown several times during %build)

 * wrong perms on plugins:

        %{_libdir}/%{name}/plugins/*.so are 0775 should be 0755

 * mixed use of %{buildroot} and $RPM_BUILD_ROOT in spec

   ---> either use the former or the later

 * large noarched-data in arched pkg (~7.5 M)

   ---> you may want to move %{_datadir}/* into an unarched -common subpkg

Fix these issues, please and I'll take another run.

Cheers,
  Björn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yoyAuHUDsp&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]