https://bugzilla.redhat.com/show_bug.cgi?id=911025 --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Status: NEEDS WORK ===== Issues ==== [!]: The URL is invalid. (404) Please provide a working URL. Looks like the github project for this module has moved to: https://github.com/montagejs/collections [!]: Upstream and this package are in violation of the BSD License. The BSD License states: "Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer." Upstream doesn't comply with this provision, and the link it provides to attempt to comply with this is 404. Consider suggesting that upstream include the BSD text in their LICENSE file as well. Regardless, you need a copy of the BSD in the Fedora package, as stated here: BTW, the correct link for the license this code was derived from now appears to be: https://github.com/montagejs/montage/blob/master/LICENSE.md ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. Derived from BSD code, but BSD license text not included. Also link to license in code is invalid. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. FPC has repeatedly expressed that they're OK with simple code use as done in this module so OK. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). nodejs macros used OK [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. % npm -q view collections version 0.1.20 [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments documented OK [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-collections-0.1.20-1.fc20.noarch.rpm nodejs-collections.noarch: W: invalid-url URL: https://github.com/kriskowal/collections HTTP Error 404: Not Found nodejs-collections.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Please fix the URL. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-collections nodejs-collections.noarch: W: invalid-url URL: https://github.com/kriskowal/collections HTTP Error 404: Not Found nodejs-collections.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' See above. Requires -------- nodejs-collections (rpmlib, GLIBC filtered): nodejs(engine) OK Provides -------- nodejs-collections: nodejs-collections npm(collections) OK Source checksums ---------------- http://registry.npmjs.org/collections/-/collections-0.1.20.tgz : CHECKSUM(SHA256) this package : 7568bf4eea66070e2cfd71bf39701ce2dbe9ff6603d8403999a7c6d549d3a6a6 CHECKSUM(SHA256) upstream package : 7568bf4eea66070e2cfd71bf39701ce2dbe9ff6603d8403999a7c6d549d3a6a6 OK Generated by fedora-review 0.4.0 (eaf16cd) last change: 2013-05-30 Buildroot used: fedora-rawhide-vanilla-x86_64 Command line :./try-fedora-review -b911025 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KxvKoRDqtm&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review