https://bugzilla.redhat.com/show_bug.cgi?id=967620 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mschwendt@xxxxxxxxx --- Comment #16 from Michael Schwendt <mschwendt@xxxxxxxxx> --- Seriously, guys, please restart the review, and don't rush. Even a brief look at the spec file raises questions: > %post -p /sbin/ldconfig > > %postun -p /sbin/ldconfig Why these scriptlets? The %files section doesn't contain anything related. > %files > %{_bindir}/%{name}* > %{_libdir}/%{name}/ > %install > jam install > find %{buildroot} -name '*.a' -exec rm -f {} ';' > find %{buildroot} -name 'INSTALL' -exec rm -f {} ';' So, first you compile and build libraries only to delete them? /usr/lib64/libedelib.a /usr/lib64/libedelib_dbus.a /usr/lib64/libedelib_gui.a > %files devel > %{_libdir}/pkgconfig/%{name}*.pc Untested pkgconfig files. They could have served as an early-warning system. Examine them with real-world pkg-config queries. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=P0FxJjQhDw&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review