https://bugzilla.redhat.com/show_bug.cgi?id=962834 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> --- * The changes are fine, except that I just had a final look at the new -doc package and noticed it contains only 15 manual pages with a total package size of 12092. As such I think it's not justified to create a separate -doc package. I recommend that you include the manual pages in the -devel package where they belong (manuals section 3). No Obsoletes are needed, since the -doc package hasn't existed before. The old packages included the man pages in the base package (wrongly): http://koji.fedoraproject.org/koji/packageinfo?packageID=8400 https://fedoraproject.org/wiki/Packaging:ReviewGuidelines | | MUST: Large documentation files must go in a -doc subpackage. | (The definition of large is left up to the packager's best judgement, | but is not restricted to size. Large can refer to either size or quantity). The %changelog doesn't tell _why_ you've moved the man pages into a subpackage. In case a future version will include "large" documentation, it would still be possible to introduce a -doc package. * EPEL5: %defattr is not needed there either, because RPM is new enough. * You're free to handle the doc changes within pkg git. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AJwegiwXLe&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review