[Bug 973159] Review Request: libguac-client-ssh - SSH support for guacd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=973159

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5492790

$ rpmlint -i -v *libguac-client-ssh.src: I: checking
libguac-client-ssh.src: W: spelling-error Summary(en_US) guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.src: W: spelling-error %description -l en_US guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.src: E: description-line-too-long C libguac-client-ssh is a
protocol support plugin for the Guacamole proxy (guacd) which
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

libguac-client-ssh.src: I: checking-url http://guac-dev.org/ (timeout 10
seconds)
libguac-client-ssh.src: I: checking-url
http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10
seconds)
libguac-client-ssh.i686: I: checking
libguac-client-ssh.i686: W: spelling-error Summary(en_US) guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.i686: W: spelling-error %description -l en_US guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.i686: E: description-line-too-long C libguac-client-ssh is a
protocol support plugin for the Guacamole proxy (guacd) which
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

libguac-client-ssh.i686: I: checking-url http://guac-dev.org/ (timeout 10
seconds)
libguac-client-ssh.i686: W: devel-file-in-non-devel-package
/usr/lib/libguac-client-ssh.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

libguac-client-ssh.x86_64: I: checking
libguac-client-ssh.x86_64: W: spelling-error Summary(en_US) guacd -> guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.x86_64: W: spelling-error %description -l en_US guacd ->
guard
The value of this tag appears to be misspelled. Please double-check.

libguac-client-ssh.x86_64: E: description-line-too-long C libguac-client-ssh is
a protocol support plugin for the Guacamole proxy (guacd) which
Your description lines must not exceed 80 characters. If a line is exceeding
this number, cut it to fit in two lines.

libguac-client-ssh.x86_64: I: checking-url http://guac-dev.org/ (timeout 10
seconds)
libguac-client-ssh.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libguac-client-ssh.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

libguac-client-ssh-debuginfo.i686: I: checking
libguac-client-ssh-debuginfo.i686: I: checking-url http://guac-dev.org/
(timeout 10 seconds)
libguac-client-ssh-debuginfo.x86_64: I: checking
libguac-client-ssh-debuginfo.x86_64: I: checking-url http://guac-dev.org/
(timeout 10 seconds)
libguac-client-ssh.spec: I: checking-url
http://guac-dev.org/pub/dist/source/libguac-client-ssh-0.8.0.tar.gz (timeout 10
seconds)
5 packages and 1 specfiles checked; 3 errors, 8 warnings.


The spelling errors can be ignored, also the devel file error (for this certain
case). So there remain too long description lines. The problem is the %name
macro which will be expanded in the resulting plain text description. Actually
we have 75 characters in line 20, after expanding we have 86.



$ licensecheck -r *
include/display.h: MPL (v1.1) GPL (unversioned/unknown version)
include/libssh_compat.h: MPL (v1.1) GPL (unversioned/unknown version)
include/buffer.h: MPL (v1.1) GPL (unversioned/unknown version)
include/char_mappings.h: MPL (v1.1) GPL (unversioned/unknown version)
include/ssh_client.h: MPL (v1.1) GPL (unversioned/unknown version)
include/terminal_handlers.h: MPL (v1.1) GPL (unversioned/unknown version)
include/cursor.h: MPL (v1.1) GPL (unversioned/unknown version)
include/common.h: MPL (v1.1) GPL (unversioned/unknown version)
include/guac_handlers.h: MPL (v1.1) GPL (unversioned/unknown version)
include/types.h: MPL (v1.1) GPL (unversioned/unknown version)
include/client.h: MPL (v1.1) GPL (unversioned/unknown version)
include/ibar.h: MPL (v1.1) GPL (unversioned/unknown version)
include/terminal.h: MPL (v1.1) GPL (unversioned/unknown version)
include/blank.h: MPL (v1.1) GPL (unversioned/unknown version)
ltmain.sh: GPL (v2 or later)
src/display.c: MPL (v1.1) GPL (unversioned/unknown version)
src/terminal_handlers.c: MPL (v1.1) GPL (unversioned/unknown version)
src/cursor.c: MPL (v1.1) GPL (unversioned/unknown version)
src/client.c: MPL (v1.1) GPL (unversioned/unknown version)
src/common.c: MPL (v1.1) GPL (unversioned/unknown version)
src/ssh_client.c: MPL (v1.1) GPL (unversioned/unknown version)
src/blank.c: MPL (v1.1) GPL (unversioned/unknown version)
src/char_mappings.c: MPL (v1.1) GPL (unversioned/unknown version)
src/guac_handlers.c: MPL (v1.1) GPL (unversioned/unknown version)
src/buffer.c: MPL (v1.1) GPL (unversioned/unknown version)
src/terminal.c: MPL (v1.1) GPL (unversioned/unknown version)
src/ibar.c: MPL (v1.1) GPL (unversioned/unknown version)


As "licensecheck" says, we have MPL v1.1 or GPL without versioning. I cannot
find the "future versions" clause anywhere, and nowhere LGPL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eAldnaCgfB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]