https://bugzilla.redhat.com/show_bug.cgi?id=949317 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |echevemaster@xxxxxxxxx Flags|needinfo? | --- Comment #2 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- There are some issues in fedora-review which appear to be false positives - Pure Ruby package must be built as noarch See: https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support this package contains C extensions, therefore are dependent arch if you don't want ship the package to el5: - %clean is not needed - BuildRoot is not needed - cleaning of buildroot in %install is not needed - %defattr is not needed - Compiler flags do not honor fedora specific. please add export CONFIGURE_ARGS="--with-cflags='%{optflags}'" above %gem_install - Please exclude cached Gem with %exclude %{gem_cache} - There are tests in the package, should be executed - Add the license file, exists in the source. - the files README CHANGELOG are twice listed, please fix it -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nbAdeEkU5c&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review