https://bugzilla.redhat.com/show_bug.cgi?id=967335 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Run the test suite in .%{gem_instdir} - Could you please run the test suite on installed gem, i.e. inside .%{gem_instdir}. If the gem is binary, you would be missing the compiled extension. * Keep .gemspec, Gemfile, Guardfile and Rakefile in -doc subpackage - This is up to you, but I would keep these files in -doc subpackage. - Alternatively, you could suggest upstream to drop them from the package, since they are not overly useful in distributed gem. - Actually, since we are there, I would question upstream about purpose of dotenv-rails.gemspec and the file lib/dotenv-rails. It seems that this should not be included at all? Neither of these are blockers, so I APPROVE the package. However, please consider to fix this nits prior importing this package into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VyE5RyX1ws&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review