https://bugzilla.redhat.com/show_bug.cgi?id=970931 Jan Kaluža <jkaluza@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jkaluza@xxxxxxxxx | |m) | --- Comment #4 from Jan Kaluža <jkaluza@xxxxxxxxxx> --- Spec URL: http://jkaluza.fedorapeople.org/pythonqt.spec SRPM URL: http://jkaluza.fedorapeople.org/pythonqt-2.1-2.fc18.src.rpm (In reply to Jan Včelák from comment #2) > - Package should contain python2-devel or python3-devel. Not python-devel. > (http://fedoraproject.org/wiki/Packaging:Python#BuildRequires) Fixed. > - Compiler warnings about broken strict-aliasing rules. I have added "-fno-strict-aliasing" to workaround this Python bug http://www.python.org/dev/peps/pep-3123/ . > - The description for the main package and -devel packages are identical. > I checked a few other -devel packages and it there was always an > additional sentence, that the -devel package includes heder files. It > should be probably added. Fixed. > - Stray dependencies present, '--as-needed' linker flag should be added. > (See rpmlint output.) Added. > - The license text contains old FSF address, please inform upstream. > I sent an email upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RbCtzqWdQS&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review