[Bug 970130] Review Request: git-extras - Little git extras

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=970130

--- Comment #3 from Björn Esser <bjoern.esser@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #2)
> [!]: Package consistently uses macro is (instead of hard-coded directory
>      names).
> 
> Just a complete use in
> '%{buildroot}%{_sysconfdir}/bash_completion.d/git-extras' line.

Alright, I missed one %{version} in Source0

      's!1\.8\.0/!%\{version\}!'

Where else to use macros?

      # These go relative to %{source0} having the complete-dirs
      # picked-up in %files-%doc later.

      install -pm 0644 man/*.html html
      install -pm 0644 man/*.md md

      %files
      %config(noreplace) %{_sysconfdir}/bash_completion.d/*
--->  %doc AUTHORS History.md LICENSE Readme.md html/ md/  <---
      %{_bindir}/*
      %{_mandir}/man*/*

#####

Updated spec/srpm

Spec URL: http://besser82.fedorapeople.org/review/git-extras/git-extras.spec
SRPM URL:
http://besser82.fedorapeople.org/review/git-extras/git-extras-1.8.0-2.fc19.src.rpm

%changelog
* Fri Jun 07 2013 Björn Esser <bjoern.esser@xxxxxxxxx> - 1.8.0-2
- added missing %%{version} in Source0

* Mon Jun 03 2013 Björn Esser <bjoern.esser@xxxxxxxxx> - 1.8.0-1
- Initial rpm release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7GLkTZa9jb&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]