https://bugzilla.redhat.com/show_bug.cgi?id=970803 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Thanks for the review! (In reply to Miro Hrončok from comment #1) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > ===== Issues ===== > > Add comment about the license to the spec. > Tell me, this is also meant for EPEL5. If not, solve all [!] bellow. Yup, I've been talking with someone who needs nodejs on EL5 in their corporate environment working on a solution here. Hopefully that will be done soon. > ===== MUST items ===== > > Generic: > [?]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > > The source contains absolutely nothing about the license. > There is WTFPL license in the repo, but please add comment about that > to the spec. > Also, be careful and add a link to the commit, where version was still > 1.0.0, but license was already WTFPL. > > https://github.com/isaacs/inherits/blob/ > 112807f2670160b6e3bafdf39e395c10ae7d0fac/LICENSE Fixed. -- Spec: http://patches.fedorapeople.org/npm/nodejs-inherits1.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-inherits1-1.0.0-10.fc19.src.rpm * Fri Jun 07 2013 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 1.0.0-10 - include LICENSE file from upstream git -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S9mdIyRfMv&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review