https://bugzilla.redhat.com/show_bug.cgi?id=954074 --- Comment #4 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Volker Fröhlich from comment #1) > error: (will be fatal in the future): value "remotebox.png" for key "Icon" > in group "Desktop Entry" is an icon name with an extension, but there should > be no extension as described in the Icon Theme Specification if the value is > not an absolute path Fixed. > Did you try to submit the desktop file? Did you ask them to include a > license file yet? Quoted from author: "I may consider adding a .desktop file in the tarball in a future release, but it's perfectly legitimate to create your own." License file quote: "The GPL version is quite clearly stated in the file share/remotebox/remotebox.xml and is viewable from the about menu. It's not necessary to include a specific LICENSE file. " > Please give a rationale for AutoReq: no. I don't know how to exclude the *.pl(RPM treated it as requires) as I've tried many solutions but they all seems useless... > I'd suggest to use the _prefix and _docdir macros in your sed invocations. Fixed. > You're not owning %{_datadir}/%{name}. Make "%{_datadir}/%{name}/*" > "%{_datadir}/%{name}". That'll do! Thanks. NEW SPEC: http://cicku.me/remotebox.spec NEW SRPM: http://cicku.me/remotebox-1.5-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Phh2Dkp0M&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review