https://bugzilla.redhat.com/show_bug.cgi?id=914936 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #3 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- (In reply to Paulo Andrade from comment #2) > Many thanks for the review. > > I added the new fes-dynamic.patch patch, that required fixing > and/or making compatible with automake 1.13 stuff and removing > some duplicated entries in autogenerated file lists to avoid > adding the same object files more than once to the linker > command line (could add -Wl,mulrefs, but too ugly...) > Do you've sent the patch to the upstream folks? > I can remove the "with_doc" macro if you prefer. It was not added > because of size of the pdf file (100kish) but kind or remaining > of my initial tests in generating documentation, and figuring > out what was required, and the almost full texlive stack is > not always "cheap" to install. You mean a local installation, in Mock or in a real environment? Of course, the texlive stuff eats up a lot of disk space and need much bandwith when updates come in. But I always try to build on a Koji server, so that I don't have to bother with that. Anyway, the doc creation is switched on (what I've missed on time I've written my first comments), so that you have to decide if it goes into a subpackage. I'm fine with the current solution, although the %with_doc macro is rather not needed. Scratch build fails for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5476519 >From build.log: + autoreconf -ifs /var/tmp/rpm-tmp.QUDUtP: line 42: autoreconf: command not found autoconf is missing from BuildRequires. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uu5URVorqE&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review