[Bug 840551] Review Request: sugar-kuku - arithmetic education game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=840551

--- Comment #45 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ Package builds in mock successfully

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball : adbfda234c4c5d31c0acd25b65e42d50cd9baacd1e171f5bcc4d96a3438fa308
upstream tarball :
adbfda234c4c5d31c0acd25b65e42d50cd9baacd1e171f5bcc4d96a3438fa308

+ License tag is valid GPLv3+

+ Rest looks as per packaging guidelines.


Suggestions:
1)  Don't use any backslash between %{buildroot} and %{_prefix}, so your
%install should look like
%{__python} ./setup.py install --prefix=%{buildroot}%{_prefix}

2) Why is changelog for -6 and -7 is same? Add correct changelog

3) You don't need to set again executable bits. remove following from spec
#chmod +x  kuku_config.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7JHDUzyaqO&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]