https://bugzilla.redhat.com/show_bug.cgi?id=841239 --- Comment #9 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Danishka, here is a official review + Package builds in mock successfully - rpmlint on rpms gave sugar-story.noarch: W: incoherent-version-in-changelog 9-3 ['9-4.fc19', '9-4'] 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 105bc01477d3dbfc157f0e49c913106f8a7f70d4f82aea5db64875b89b678fa9 upstream tarball:105bc01477d3dbfc157f0e49c913106f8a7f70d4f82aea5db64875b89b678fa9 - License tag is GPLv3 which is not completely valid. + Rest looks as per packaging guidelines. Suggestions: 1) Remove the following line from %prep. I see latest upstream release nah.po is fixed. rm po/nah.po 2) License tag should be GPLv3+ and MIT. Read https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses Also, Add a comment above license tag # grecord.py and sprites.py is in MIT and all other files in GPLv3+ 3) You may want to have release tag number 3 and not 4 for last update. But now when you will fix above issue 1 by adding changelog, rpmlint warning will go away. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1gOJxFsJJu&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review