Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gle - Graphics Layout Engine https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229676 ------- Additional Comments From terjeros@xxxxxxxxxxxx 2007-03-12 08:27 EST ------- > * Encoding > - Well, you tried to change LICENSE.txt to UNIX format by dos2unix, > however, it is not enough. Fixed. > * Conditional dependency > - Mockbuild log says: > --------------------------------------------------- > checking for XOpenDisplay in -lX11... no > ..... > ** X11 preview support: no > --------------------------------------------------- > Please fix configure (NOTE: not configure.in but > configure. Please don't use autotool as much as > possible) (around the line 2709). Unable to reproduce, qt4-devel should bring in all needed X11 libs? > * Timestamps > - This package tries to install some files from original > zip file without any modification, such as Fixed. > * rpmlint > - not silent. Fixed. > * License > - Some files are not licensed under BSD. > A. GPL > ------------------------------------------------------ > ./src/gui/about.* > ./src/gui/arc.* > ( and many other files under ./src/gui ) > ------------------------------------------------------ > B. assumely GPL (however, would you contact upstream?) > ------------------------------------------------------ > ./src/gui/gsinc/gdevdsp.h > ( and some other files under ./src/gui/gsinc ) > ------------------------------------------------------ Fixed by creating subpackage for gui with GPL license, ok? > For sourceURL, please check: > http://fedoraproject.org/wiki/Packaging/SourceURL Fixed. Updated spec: http://web.phys.ntnu.no/~terjeros/gle/gle.spec srpm: http://web.phys.ntnu.no/~terjeros/gle/gle-4.0.12-3.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review