https://bugzilla.redhat.com/show_bug.cgi?id=919851 Shakthi Kannan <shakthimaan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_DEV Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Shakthi Kannan <shakthimaan@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 122880 bytes in 17 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- $ rpmlint ghc-IfElse.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-IfElse-0.85-1.fc17.x86_64.rpm ghc-IfElse.x86_64: W: spelling-error Summary(en_US) Anaphoric -> Aphoristic ghc-IfElse.x86_64: W: spelling-error %description -l en_US Anaphoric -> Aphoristic 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ghc-IfElse-devel-0.85-1.fc17.x86_64.rpm ghc-IfElse-devel.x86_64: W: spelling-error Summary(en_US) Anaphoric -> Aphoristic ghc-IfElse-devel.x86_64: W: spelling-error %description -l en_US Anaphoric -> Aphoristic 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ghc-IfElse-0.85-1.fc17.src.rpm ghc-IfElse.src: W: spelling-error Summary(en_US) Anaphoric -> Aphoristic ghc-IfElse.src: W: spelling-error %description -l en_US Anaphoric -> Aphoristic 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Diff spec file in url and in SRPM --------------------------------- --- /tmp/919851-ghc-IfElse/srpm/ghc-IfElse.spec 2013-06-05 12:40:35.642299676 +0530 +++ /tmp/919851-ghc-IfElse/srpm-unpacked/ghc-IfElse.spec 2013-06-05 12:40:36.015299683 +0530 @@ -4,5 +4,5 @@ %global pkg_name IfElse -%global common_summary Anaphoric and misc control-flow +%global common_summary Anaphoric and miscellaneous useful control-flow %global common_description Anaphoric and miscellaneous useful control-flow. Source checksums ---------------- http://hackage.haskell.org/packages/archive/IfElse/0.85/IfElse-0.85.tar.gz : CHECKSUM(SHA256) this package : 8ad3bfc3e2c867e6330d9bff874b3105476c35b2e1638fd448f233e9f80addcd CHECKSUM(SHA256) upstream package : 8ad3bfc3e2c867e6330d9bff874b3105476c35b2e1638fd448f233e9f80addcd Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-17-x86_64 Command line :/usr/bin/fedora-review -b 919851 Successful Koji builds for F17, F18, F19, F20: Koji f18 http://koji.fedoraproject.org/koji/taskinfo?taskID=5471752 Koji f17 http://koji.fedoraproject.org/koji/taskinfo?taskID=5471753 Koji f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=5471754 Koji f19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5471755 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3SNMUdTyS0&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review