https://bugzilla.redhat.com/show_bug.cgi?id=970009 --- Comment #19 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to David Woodhouse from comment #18) > [!]: Package do,es not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf %{buildroot} present but not required Fixed this, it is created by rpmdev-newspec even on new (rpm 4.11) templates. > [!]: update-desktop-database is invoked when required > Note: desktop file(s) in stoken-gui This is no mime type installed, so this should not be required [1]. > [!]: Package installs a %{name}.desktop using desktop-file-install if there > is > such a file. SPEC file already calls desktop-file-validate, as specified by the packaging guidelines desktop-file-install should be run only if the package does not install the desktop file on its own [2]. > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0 I will revert to version 0.2, since it's released and the changes introduced still do not allow us to avoid libtomcrypt. I don't see any benefit now for using version 0.3; unless it's released before the end of the review. I would also have to use the SourceURL for github prereleases according to the guidelines [3] which I would rather avoid. [1] http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database [2] http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage [3] https://fedoraproject.org/wiki/Packaging:SourceURL#Github -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=492YwMYa1H&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review