[Bug 840437] Review Request: sugar-xoeditor - editor for xo icon colors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=840437

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|177841 (FE-NEEDSPONSOR)     |
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mario.blaettermann@xxxxxxxx
                   |                            |m
              Flags|                            |fedora-review?

--- Comment #13 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
(In reply to Danishka Navin from comment #8)
> You better asked before closing. :)
> 
Sorry for the inconvenience. I will do the review for you in return :)


python-devel is deprecated, use python2-devel instead:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

%defattr(-,root,root,-)
is obsolete and can be dropped for all currently supported Fedora versions and
EPEL>=6.


COPYING contains the GPLv3, not GPLv2. Moreover, licensecheck says:

$ licensecheck -r *
game.py: GPL (v3 or later)
setup.py: *No copyright* UNKNOWN
sprites.py: MIT/X11 (BSD like)
toolbar_utils.py: GPL (v3 or later)
XOEditorActivity.py: GPL (v3 or later)

That's why the license tag has to be "GPLv3+ and MIT"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ruccwT2R5G&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]