https://bugzilla.redhat.com/show_bug.cgi?id=967334 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Summary - The summary is quite brief. Would you mind to add more details, e.g. something from beginning of README * pushd .%{gem_instdir} - In the %check section, could you please replace the "pushd ." with more accurate "pushd .%{gem_instdir}"? Although in this case, it works quite ok, it would fails, if the gem contains binary extension, since now you are testing the unpacked gem, instead of installed gem. * Move README.md into -doc subpackage - I prefer to put all files not needed for runtime into -doc subpackage. However, this is my personal preference, so it is up to you. * Keep Gemfile and Rakefile in -doc subpackage - Although these files are not needed for Fedora, I prefer to keep them in -doc subpackage as long as they are shipped by upstream. Nevertheless, this is not blocker. Nevertheless, the above are just minor fix so I APPROVE the package, but please fix the issues prior import into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eOwdKqgkWU&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review