Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gettext https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225791 ------- Additional Comments From petersen@xxxxxxxxxx 2007-03-12 04:33 EST ------- > * Summary: > - Please don't end with dots. > > * Prereq > - Deprecated. Use Requires(post) and Requires(preun) fixing > * Source2 > - SOURCE files should not have executable permission. Not sure how to fix this: the python script is executable in cvs. > ? BuildRoot tag > - This BuildRoot does not meet current Fedora policy. Fixing. > * Parallel make > - Please check if parallel make is possible. I will try a build with parallel make. > * %{makeinstall} macro > - Avoid this if possible. replacing > * Timestamps > --------------------------------------------- > install -m 755 %SOURCE2 ${RPM_BUILD_ROOT}/%{_bindir}/msghack > --------------------------------------------- > - Change to "install -p -m 755'. This is a script is keeping timestamp > is recommended. > - Well, perhaps also for this package > --------------------------------------------- > make install INSTALL="%{__install} -p" ..... > --------------------------------------------- > works well to keep timestamps on some files. fixing and adding > * gettext mo files > Cannot this be treated by %find_lang macro? Will look into this. > * One line command in %postun etc... > - Please use "-p" option. fixing > B. File check > - Directory ownership issue > /usr/share/locale/en@boldquot filesystem-2.4.2-1.fc7 > /usr/share/locale/en@boldquot/LC_MESSAGES filesystem-2.4.2-1.fc7 > /usr/share/locale/en@quot filesystem-2.4.2-1.fc7 > /usr/share/locale/en@quot/LC_MESSAGES filesystem-2.4.2-1.fc7 removing dirs > - Static archive > * Would you explain why static archive is needed, or just split > these to -static subpackage? I added --disable-static for now. > C. rpmlint issue > - Please use %% in %changelog for macros. fixing > - Would you explain if the status of > unversioned-explicit-provides devel(libintl) > is proper (and why this is required)? No idea. Probably some historical artefact. Perhaps it can just be removed? > - Would you explain the status of /usr/lib/preloadable_libintl.so? > * Currently this has 0644 permission Let me look into it. > - There are many 'spurious-executable-perm' complaint. > - And somes are 'wrong-script-interpreter' > - Check if some zero-length files are needed. To be honest I am tempted just to remove all the examples completely from gettext-devel or at least move them to another subpackage. > D. NOTES: > - /usr/share/aclocal is not owned by this package and > -devel package has some files under this directory. > > Generally this status is not allowed, however, it is still under > discussion about Ok. Let me update here again when the changes are in cvs and the buildsystem. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review