[Bug 970393] Review Request: foo2zjs - Driver for printers of various wire protocols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=970393

David Woodhouse <dwmw2@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwmw2@xxxxxxxxxxxxx

--- Comment #2 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> ---
There's a bunch of rpmlint warnings about this. Sorry, I feel like such a
hypocrite when pointing this out, since you started with a package I created
myself :)

The spelling-error warnings are all OK, I think, and the invalid-url is also
fine given the way that upstream does (or *doesn't* do, more to the point)
release management.

But the incorrect-fsf-address should probably be fixed (not sure of packaging
guidelines there; at least in the files that get shipped lik foo2zjs-wrapper),
and manual-page-warning usually does actually mean that the man page is being
misrendered.

I think the dangerous-command-in-%post is probably fine too, as long as that's
what other similar packages in Fedora are doing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wuuMXfFbpF&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]