[Bug 970009] Review Request: stoken - Token code generator compatible with RSA SecurID 128-bit (AES) token

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=970009

--- Comment #7 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> ---
Why set CFLAGS=$RPM_OPT_FLAGS in %build? That's done by default anyway. Is that
a leftover from an experiment with *changing* CFLAGS?

Perhaps you did that when you noticed the errant -O0 that you get by adding
--enable-debug? We'll want upstream to give us a way to build with -O2 -ggdb
which is our normal CFLAGS, rather than forcibly either overriding it to -O0 or
stripping the debug info.

If you apply the patch I just sent you for using GnuTLS, you'll need to run
autoreconf. And then you don't need to hack the libtool script with sed to fix
the stupid rpath brokenness. Is that something you (should) have reported to
the upstream maintainer, to make sure it's not present in the next release?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oKSUq8xPIi&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]