https://bugzilla.redhat.com/show_bug.cgi?id=962651 Praveen Kumar <kumarpraveen.nitdgp@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |kumarpraveen.nitdgp@gmail.c | |om Flags|needinfo? | Flags| |fedora-review? --- Comment #6 from Praveen Kumar <kumarpraveen.nitdgp@xxxxxxxxx> --- Hi Michel, I already did a formal review, is below issues resolved? As you said we don't have to provide a major update for f18, just have to unblock it for dependent applications. I assigned it to myself now. Issues: ======= - Package do not use a name that already exist Note: A package already exist with this name, please check https://admin.fedoraproject.org/pkgdb/acls/name/bamf See: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names - Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. - Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed - License field in the package spec file matches the actual license. It should be v2+ and v3+. GPL (v2 or later) ----------------- /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-application-private.h /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-tab.c /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-tab.h /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/lib/libbamf/bamf-view-private.h /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/ltmain.sh GPL (v3 or later) ----------------- /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/tests/libbamf/test-libbamf.c /var/lib/mock/fedora-17-x86_64/root/builddir/build/BUILD/bamf-0.3.6/tests/libbamf/test-matcher.c -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kYcNk8KueR&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review