https://bugzilla.redhat.com/show_bug.cgi?id=912048 --- Comment #2 from Gianluca Sforna <giallu@xxxxxxxxx> --- Basic things first. Even if the tarball is called mpDris2 I would still prefer to call the package (and spec file) all lowercase. I checked and other distros are already doing that, makes it easier for command line users to get it right. Package builds in mock for Fedora 19, rpmlint on the results says: rpmlint /var/lib/mock/fedora-19-x86_64/result/*.rpm mpDris2.noarch: W: spelling-error Summary(en_US) mpd -> mod, mp, pd mpDris2.noarch: W: spelling-error %description -l en_US mpd -> mod, mp, pd mpDris2.noarch: W: non-conffile-in-etc /etc/xdg/autostart/mpDris2.desktop mpDris2.noarch: W: no-manual-page-for-binary mpDris2 mpDris2.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/mpDris2.mo mpDris2.src: W: spelling-error Summary(en_US) mpd -> mod, mp, pd mpDris2.src: W: spelling-error %description -l en_US mpd -> mod, mp, pd 2 packages and 0 specfiles checked; 0 errors, 7 warnings. We can pretty much ignore spelling warnings. the .desktop in /etc/xdg/autostart is better to be marked as %config(noreplace). AFAIK, this is not on the guidelines but if an admin changes the file he expects changes to be preserved on upgrades (see for instance bug #842318) Language file, even if it's only one, must be handled by %find_lang as shown in: http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files Please fix these points and I think we are all set to approve the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yuJABxfd99&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review