[Bug 964318] Review Request: python-vm-builder - Ubuntu's vmbuilder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=964318

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m

--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
python-devel is deprecated, use python2-devel instead:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

%build
# Remove CFLAGS=... for noarch packages (unneeded)
Well, it is convenient to use the spec template provided by rpmdev-newspec, but
you should consider to do what it proposes. Remove the CFLAGS statement because
your package is noarch.

%{_sysconfdir}/vmbuilder/* means your package doesn't own the folder, just the
containing files. Please use %{_sysconfdir}/vmbuilder to also own the folder.

The GPL forces us (and also upstream developers) to ship the license text
within a package. Please add the plain text version:
http://www.gnu.org/licenses/gpl.txt


Instead of repeating the summary once again, you could use a more specific
description from Launchpad:

"Install virtual machines in a snap without ever actually booting a virtual
machine."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=p44a1Y9vkB&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]