https://bugzilla.redhat.com/show_bug.cgi?id=969700 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@xxxxxxxx | |m --- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- $ rpmlint -i -v * libccp4.src: I: checking libccp4.src: W: spelling-error %description -l en_US keyworded -> key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US subcomponents -> sub components, sub-components, subcontinents The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US centred -> centered, cent red, cent-red The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US syminfo -> misinform The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US sgtbx -> Sgt The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US cctbx -> CCTV The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US resizable -> re sizable, re-sizable, resealable The value of this tag appears to be misspelled. Please double-check. libccp4.src: W: spelling-error %description -l en_US resized -> resided, re sized, re-sized The value of this tag appears to be misspelled. Please double-check. libccp4.src: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4.src:12: W: unversioned-explicit-obsoletes gpp4 The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. libccp4.src: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/libccp4-6.3.1.tar.gz (timeout 10 seconds) libccp4.i686: I: checking libccp4.i686: W: spelling-error %description -l en_US keyworded -> key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US subcomponents -> sub components, sub-components, subcontinents The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US centred -> centered, cent red, cent-red The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US syminfo -> misinform The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US sgtbx -> Sgt The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US cctbx -> CCTV The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US resizable -> re sizable, re-sizable, resealable The value of this tag appears to be misspelled. Please double-check. libccp4.i686: W: spelling-error %description -l en_US resized -> resided, re sized, re-sized The value of this tag appears to be misspelled. Please double-check. libccp4.i686: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4.i686: W: obsolete-not-provided gpp4 If a package is obsoleted by a compatible replacement, the obsoleted package should also be provided in order to not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the Provides. libccp4.i686: W: shared-lib-calls-exit /usr/lib/libccp4c.so.0.0.0 exit@GLIBC_2.0 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. libccp4.x86_64: I: checking libccp4.x86_64: W: spelling-error %description -l en_US keyworded -> key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US subcomponents -> sub components, sub-components, subcontinents The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US datasets -> data sets, data-sets, databases The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US centred -> centered, cent red, cent-red The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US syminfo -> misinform The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US sgtbx -> Sgt The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US cctbx -> CCTV The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US resizable -> re sizable, re-sizable, resealable The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: W: spelling-error %description -l en_US resized -> resided, re sized, re-sized The value of this tag appears to be misspelled. Please double-check. libccp4.x86_64: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4.x86_64: W: obsolete-not-provided gpp4 If a package is obsoleted by a compatible replacement, the obsoleted package should also be provided in order to not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the Provides. libccp4.x86_64: W: shared-lib-calls-exit /usr/lib64/libccp4c.so.0.0.0 exit@GLIBC_2.2.5 This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. libccp4-debuginfo.i686: I: checking libccp4-debuginfo.i686: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4-debuginfo.x86_64: I: checking libccp4-debuginfo.x86_64: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4-devel.i686: I: checking libccp4-devel.i686: W: spelling-error %description -l en_US keyworded -> key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4-devel.i686: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libccp4-devel.x86_64: I: checking libccp4-devel.x86_64: W: spelling-error %description -l en_US keyworded -> key worded, key-worded, keyword ed The value of this tag appears to be misspelled. Please double-check. libccp4-devel.x86_64: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/ (timeout 10 seconds) libccp4-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libccp4.spec:12: W: unversioned-explicit-obsoletes gpp4 The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. libccp4.spec: I: checking-url ftp://ftp.ccp4.ac.uk/opensource/libccp4-6.3.1.tar.gz (timeout 10 seconds) 7 packages and 1 specfiles checked; 0 errors, 37 warnings. Spelling errors to be addressed: subcomponents → sub components centred → centered The other ones can be ignored in my opinion. If you set an "Obsoletes" tag, you should also use a "Provides" tag for the same package, to get a proper upgrade path. Because of that we recognize your package as the successor of all gpp4 versions, explicite versioning is unneeded. The exit() call is not up to you to fix, but should be filed as an upstream bug. Some parts of the spec file are obsolete for Fedora and EPEL <=5: * The initial cleaning of %{buildroot} in %install * The %clean section * The %defattr line in %files Requires: %{name} = %{version}-%{release} has to be Requires: %{name}%{?_isa} = %{version}-%{release} To require pkgconfig for the -devel package is unneeded, see what rpm adds automatically: $ rpm -qpR libccp4-devel-6.3.1-1.fc19.x86_64.rpm /usr/bin/pkg-config libccp4 = 6.3.1-1.fc19 libccp4c.so.0()(64bit) libccp4f.so.0()(64bit) pkgconfig rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 Don't mix %{buildroot} and $RPM_BUILD_ROOT in the same spec file. Your package is LGPL licensed. This is OK so far, but you have to ship COPYING.LESSER instead of COPYING (which addresses the GPLv3). The latter doesn't affect any file in the tarball and can be ignored: $ licensecheck -r * build-aux/ltmain.sh: GPL (v2 or later) ccp4/cmtzlib.h: LGPL ccp4/cmap_stats.h: LGPL ccp4/cvecmat.c: LGPL ccp4/ccp4_types.h: LGPL ccp4/ccp4_parser.h: LGPL ccp4/cvecmat.h: LGPL ccp4/ccp4_general.c: LGPL ccp4/pack_c.h: *No copyright* UNKNOWN ccp4/ccp4_utils.h: LGPL ccp4/ccp4_array.c: LGPL ccp4/csymlib.h: LGPL GENERATED FILE ccp4/cmap_labels.c: LGPL ccp4/cmap_stats.c: LGPL ccp4/w32mvs.h: LGPL ccp4/ccp4_unitcell.c: LGPL ccp4/cmap_errno.h: LGPL ccp4/cmap_close.c: LGPL ccp4/mtzdata.h: LGPL ccp4/ccp4_errno.h: LGPL ccp4/vmslibrary.c: LGPL ccp4/cmap_skew.h: LGPL ccp4/cmap_symop.c: LGPL ccp4/cmap_data.h: LGPL ccp4/cmap_accessor.c: LGPL ccp4/cmtzlib.c: LGPL ccp4/cmap_data.c: LGPL ccp4/library_file.h: LGPL ccp4/w32mvs.c: LGPL ccp4/cmap_open.c: LGPL ccp4/library_file.c: LGPL ccp4/ccp4_vars.h: LGPL ccp4/cmaplib.h: LGPL ccp4/overview.h: LGPL ccp4/ccp4_file_err.h: LGPL ccp4/ccp4_program.h: LGPL ccp4/cmap_labels.h: LGPL ccp4/ccp4_parser.c: LGPL ccp4/cmap_skew.c: LGPL ccp4/ccp4_general.h: LGPL ccp4/ccp4_array.h: LGPL ccp4/csymlib.c: LGPL ccp4/cmap_header.h: LGPL ccp4/library_utils.c: LGPL ccp4/cmaplib_f.h: LGPL ccp4/ccp4_fortran.h: LGPL ccp4/ccp4_program.c: LGPL ccp4/library_err.c: LGPL ccp4/ccp4_spg.h: LGPL ccp4/ccp4_unitcell.h: LGPL ccp4/pack_c.c: LGPL ccp4/ccp4_sysdep.h: LGPL ccp4/cmap_header.c: LGPL fortran/ccp4_parser_f.c: LGPL fortran/lgglib.f: UNKNOWN fortran/ccp4_general_f.c: LGPL fortran/libhtml.f: UNKNOWN fortran/sorting_main.f: UNKNOWN fortran/keyparse.f: UNKNOWN fortran/rwbrook.f: *No copyright* UNKNOWN fortran/modlib.f: *No copyright* UNKNOWN fortran/pxxml.f: UNKNOWN fortran/csymlib_f.c: LGPL fortran/plot84lib.f: *No copyright* UNKNOWN fortran/ccp4_unitcell_f.c: LGPL fortran/plotsubs.f: *No copyright* UNKNOWN fortran/dna_output.f: UNKNOWN fortran/fftlib.f: UNKNOWN fortran/ccplib.f: *No copyright* UNKNOWN fortran/testlib.f: *No copyright* UNKNOWN fortran/w32mvs.f: UNKNOWN fortran/ccp4_diskio_f.c: LGPL fortran/library_f.c: LGPL fortran/cmaplib_f.c: LGPL fortran/cmtzlib_f.c: LGPL fortran/pack_f.f: UNKNOWN fortran/parser.f: *No copyright* UNKNOWN Only one of the build files (not part of the package) is GPL licensed. The other build scripts seems to be 3 clause BSD, also ignorable. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BcTOh2gPqf&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review