Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Crypt-CHAP - Class to generate CHAP packets Alias: pear-Crypt-CHAP https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222597 Fedora@xxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | Flag|fedora-review? |fedora-review+ ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2007-03-11 14:11 EST ------- === REVIEW === :) source files match upstream: b09ba7b851f85528638d9a9dae67b1c9 Crypt_CHAP-1.0.0.tgz :) package meets naming and packaging guidelines. :) specfile is properly named, is cleanly written and uses macros consistently. :) dist tag is present. :) build root is correct (second form). :) license field matches the actual license. :) license is open source-compatible (BSD). :) latest version is being packaged (1.0.0) :) BuildRequires are proper. :) %clean is present. :) package builds in mock (FC6). :) package installs properly :/ rpmlint output acceptable W: php-pear-Crypt-CHAP no-documentation :) final provides are sane: php-pear(Crypt_CHAP) = 1.0.0 php-pear-Crypt-CHAP = 1.0.0-1.fc7 :) final Requires are sane: php-mcrypt php-mhash php-pear(PEAR) :) %check is not present; :) owns the directories it creates :) no duplicates in %files. :) file permissions are appropriate. :) scriplets are ok (pear install) :) code, not content. :/ no documentation. === APPROVED === -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review