https://bugzilla.redhat.com/show_bug.cgi?id=967568 Eduardo Echeverria <echevemaster@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+ --- Comment #8 from Eduardo Echeverria <echevemaster@xxxxxxxxx> --- Hi Wolfgang: mintmenu.noarch: E: explicit-lib-dependency python-xlib this is a rpmlint false positive, rpmlint assumes all dependencies which contain the string "lib" are traditional library (with .so files inside) packages and can be autodetected, it's no applicable in this case Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: glib-compile-schemas is run if required Note: gschema file(s) in mintmenu [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 17 files have unknown license. Detailed output of licensecheck in /home/makerpm/967568-mintmenu/licensecheck.txt Contains header license of GPLv2, packager should contact to upstream to add the boilerplatre [x]: The spec file handles locales properly. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 40960 bytes in 3 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mintmenu-5.4.9-5.fc20.noarch.rpm mintmenu.noarch: E: explicit-lib-dependency python-xlib mintmenu.noarch: W: obsolete-not-provided mintmenu-lang mintmenu.noarch: W: no-manual-page-for-binary mintmenu 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mintmenu mintmenu.noarch: E: explicit-lib-dependency python-xlib mintmenu.noarch: W: obsolete-not-provided mintmenu-lang mintmenu.noarch: W: no-manual-page-for-binary mintmenu 1 packages and 0 specfiles checked; 1 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- mintmenu (rpmlib, GLIBC filtered): /bin/sh /usr/bin/env /usr/bin/python beesu mate-menu-editor mate-panel pygtk2 pygtk2-libglade python python-configobj python-xlib pyxdg system-logos yumex Provides -------- mintmenu: mintmenu Source checksums ---------------- http://packages.linuxmint.com/pool/main/m/mintmenu/mintmenu_5.4.9.tar.gz : CHECKSUM(SHA256) this package : 5685f586e383f62f66b55d051b56475182061abc0bad3989c852a9544f74bdc7 CHECKSUM(SHA256) upstream package : 5685f586e383f62f66b55d051b56475182061abc0bad3989c852a9544f74bdc7 http://packages.linuxmint.com/pool/main/m/mint-translations/mint-translations_2013.05.04.tar.gz : CHECKSUM(SHA256) this package : 12bc72e094574624d8b45856e3dad5a6fd26ac0b1ad3cd40d8b6ec4b67f6231b CHECKSUM(SHA256) upstream package : 12bc72e094574624d8b45856e3dad5a6fd26ac0b1ad3cd40d8b6ec4b67f6231b ---------------- PACKAGE APPROVED ---------------- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=36089rO9Dq&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review