[Bug 755093] Review Request: mactel-boot - boot tools for Intel Apple hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=755093

Anatol Pomozov <anatol.pomozov@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anatol.pomozov@xxxxxxxxx

--- Comment #40 from Anatol Pomozov <anatol.pomozov@xxxxxxxxx> ---
Hi, I am cleaning up mactel-boot package in Linux Arch
https://aur.archlinux.org/packages/mactel-boot/ and I have 2 minor nitpick
suggestions wrt Makefile found in hfs-bless tool
http://www.codon.org.uk/~mjg59/mactel-boot/mactel-boot-0.9.tar.bz2


1) Install hfs-bless tool to /usr/bin instead of /usr/sbin. Arch merged these
directories into on /usr/bin and if I understand following document correctly
then Fedora does the same https://fedoraproject.org/wiki/Features/UsrMove

2) Makefile should respect $CFLAGS. Build system might want to set system
default compilation flags. Currently the project Makefile has line
$(CC) -g -o hfs-bless bless.c
but I believe it should like
$(CC) $(CFLAGS) -o hfs-bless bless.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ueACgzDM8o&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]