https://bugzilla.redhat.com/show_bug.cgi?id=907007 Björn Esser <bjoern.esser@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Flags|fedora-review? | Flags| |fedora-review+ Last Closed| |2013-06-01 01:15:57 --- Comment #19 from Björn Esser <bjoern.esser@xxxxxxxxx> --- Just a hint on sed-usage: sed -e "s/some/something/" If you want to pre/suffix some phrase with sed's search-replace, searched phrase can be substituted with & (ambersand), which will make the process less error-prone in case of possible typos: sed -e "s/some/&thing/" <-- will suffix to phrase --> something sed -e "s/some/lone&/" <-- will prefix to phrase --> lonesome ##### Just a hint for el5-packaging: If you want to package this for EPEL5, too, you should add the needed BuildRoot-tag and `rm -rf "%{buildroot}"` on top of %install and %clean targets inside the spec-file. For further infos see: https://fedoraproject.org/wiki/Category:EPEL ##### Package is fine. Nothing more to say, see below. ##### Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. static-stuff goes to -static subpkg [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: Static libraries in -static subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 72 files have unknown license. GPLv2+: ltmain.sh from autotools, rest is MIT [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 30720 bytes in 4 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. post-release git-snapshot [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: unittest-cpp-1.4-9.20130509gitc42e68b.fc20.x86_64.rpm unittest-cpp-devel-1.4-9.20130509gitc42e68b.fc20.x86_64.rpm unittest-cpp-static-1.4-9.20130509gitc42e68b.fc20.x86_64.rpm unittest-cpp-static.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint unittest-cpp-devel unittest-cpp-static unittest-cpp unittest-cpp-static.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- unittest-cpp-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libUnitTest++.so.1()(64bit) unittest-cpp(x86-64) unittest-cpp-static (rpmlib, GLIBC filtered): unittest-cpp(x86-64) unittest-cpp (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- unittest-cpp-devel: pkgconfig(unittest-cpp) unittest-cpp-devel unittest-cpp-devel(x86-64) unittest-cpp-static: unittest-cpp-static unittest-cpp-static(x86-64) unittest-cpp: libUnitTest++.so.1()(64bit) unittest-cpp unittest-cpp(x86-64) Source checksums ---------------- https://github.com/unittest-cpp/unittest-cpp/archive/c42e68bb999d01da9ec71b67ff1a2cbd6ec1b6a6/unittest-cpp-1.4-c42e68b.tar.gz : CHECKSUM(SHA256) this package : b64c492f2f600ad15bd7f4324af2b43826aaa3546e4aece9967a055dbba13691 CHECKSUM(SHA256) upstream package : b64c492f2f600ad15bd7f4324af2b43826aaa3546e4aece9967a055dbba13691 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 907007 ##### So this one is APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6rikeTrjvL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review