https://bugzilla.redhat.com/show_bug.cgi?id=877607 --- Comment #5 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> --- (In reply to Björn Esser from comment #4) > Review revealed: > > > BLOCKERS: > > * No fully versioned dependency in pythia8-hepmcinterface-devel, > pythia8-data, pythia8-examples, pythia8-doc present. > Should be "Requires: %{name}%{?_isa} = %{version}-%{release}", > if needed or present. pythia8-hepmcinterface-devel has Requires: %{name}-hepmcinterface%{?_isa} = %{version}-%{release} Requires: %{name}-devel%{?_isa} = %{version}-%{release} These dependencies are both motivated because of the symlink that points to the library in the pythia8-hepmcinterface package and that the installed header file in turn includes header files in pythia8-devel respectively. No such motivation exists for a direct dependency on the main package. The requirement that a package containing the license file is installed is ensured by the dependency chain (both the dependencies above in turn have a versioned dependency on the main package). The guidelines do not require a direct dependency for this purpose. For the others (pythia8-data, pythia8-examples, pythia8-doc) there is also no need for a dependecy on the main package. The only reason for such a dependency on the main package would be to install a package containing the license file. However, these three subpackages have their own copy of the license file included instead. The guidelines say that the dependency must be fully qualified when needed and present. In thes cases the dependencies are neither needed nor present. The guidelines do not say make sure to always add a dependencies on the main package. > * rpmlint is not so happy (ignored and false positives snipped)... > > Rpmlint > ------- > Checking: pythia8-8.1.76-2.fc20.x86_64.rpm > pythia8-devel-8.1.76-2.fc20.x86_64.rpm > pythia8-hepmcinterface-8.1.76-2.fc20.x86_64.rpm > pythia8-hepmcinterface-devel-8.1.76-2.fc20.x86_64.rpm > pythia8-data-8.1.76-2.fc20.noarch.rpm > pythia8-examples-8.1.76-2.fc20.noarch.rpm > pythia8-doc-8.1.76-2.fc20.noarch.rpm > pythia8-examples.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/pythia8-examples-8.1.76/softsusy.spc > pythia8-doc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/pythia8-doc-8.1.76/pythia.css > 7 packages and 0 specfiles checked; 0 errors, 14 warnings. > > ---> Fix wrong-file-end-of-line-encoding by using > `sed -i 's/\r//' <file_to_strip> ` as recommended in wiki: > https://fedoraproject.org/wiki/Common_Rpmlint_issues \ > #wrong-file-end-of-line-encoding Fixed (though I prefer using dos2unix - which the quoted guideline offers as a valid option). > NON-BLOCKERS: > > * If want to pkg for el5 you should add a %clean-target > (like in blocking review-bugs) to spec-file... Thanks. Added. > * Ask upstream to replace calling `exit()` with throwing an exception, > if possible: > > pythia8-hepmcinterface.x86_64: W: shared-lib-calls-exit > /usr/lib64/libhepmcinterface.so.8.1.76 exit@GLIBC_2.2.5 The calls to exit are condisionalized in the code: if ( m_crash_on_problem ) exit(1); and m_crash_on_problem is false by default in the constructor. So you need to actively enable the calls to exit() if you want them. New version: Spec URL: http://grid.tsl.uu.se/review/pythia8.spec SRPM URL: http://grid.tsl.uu.se/review/pythia8-8.1.76-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=daxG3iuhHX&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review