Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tetrinetx - The GNU TetriNET server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225400 jpmahowald@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jpmahowald@xxxxxxxxx Flag| |fedora-review? ------- Additional Comments From jpmahowald@xxxxxxxxx 2007-03-10 21:17 EST ------- Does build in devel x86_64 rpmlint: E: tetrinetx non-standard-uid /var/games/tetrinetx tetrinetx E: tetrinetx non-standard-gid /var/games/tetrinetx tetrinetx E: tetrinetx non-standard-uid /etc/tetrinetx/game.pmotd tetrinetx E: tetrinetx non-standard-gid /etc/tetrinetx/game.pmotd tetrinetx E: tetrinetx non-standard-uid /etc/tetrinetx/game.conf tetrinetx E: tetrinetx non-standard-gid /etc/tetrinetx/game.conf tetrinetx E: tetrinetx zero-length /etc/tetrinetx/game.conf E: tetrinetx non-standard-uid /var/run/tetrinetx tetrinetx E: tetrinetx non-standard-gid /var/run/tetrinetx tetrinetx E: tetrinetx non-standard-uid /var/log/tetrinetx tetrinetx E: tetrinetx non-standard-gid /var/log/tetrinetx tetrinetx E: tetrinetx non-standard-uid /etc/tetrinetx/game.motd tetrinetx E: tetrinetx non-standard-gid /etc/tetrinetx/game.motd tetrinetx E: tetrinetx non-standard-uid /etc/tetrinetx/game.secure tetrinetx E: tetrinetx non-standard-gid /etc/tetrinetx/game.secure tetrinetx E: tetrinetx non-readable /etc/tetrinetx/game.secure 0600 Originally I thought the games user might be preferable. Games SIG recommends scorebord files setuid/setgid games if necessary. However they also want daemons to run as a seperate user, so I'd leave it owned by tetrinetx. http://fedoraproject.org/wiki/Extras/SIGs/Games I'm not sure of the legality of including the word "tetris". I don't see it in the tetrinetx docs. Good: + license GPL, COPYING included + init script + %clean + macro usage throughout + spec commented + source matches upstream + proper BuildRoot + follows naming guidelines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review