https://bugzilla.redhat.com/show_bug.cgi?id=957918 Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |182235 (FE-Legal) --- Comment #5 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- There are several embedded chunks for different kinds of decoders. License is clean and I am not aware of any possible patent problems (e.g. codecs) https://fedoraproject.org/wiki/Software_Patents The package only implements "historic" formats. I do not think I have enough authority to say it is ok for Fedora, I am almost sure it is, but lifting FE-LEGAL, now that it has been cleaned after removal of most of the test cases (and binary test input files) from the main tarball. Non legal issues below. The -devel package should have %{name}%{?_isa} = %{version}-%{release} instead of %{name} = %{version}-%{release} I believe the embedded "mini" gzip, xz, etc decoders are ok due to very small code and most of those do not have a related devel/runtime library anyway. Upstream may be interested on these: o The fnmatch implementation is linked in, but in the final library, the symbol used comes from glibc, maybe fnmatch.{c,h} belongs to src/win32 ? o Not sure if this warnings is generated on systems other than rawhide (4.8.0): gcc -c -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -Wno-unused-but-set-variable -Wno-unused-result -Wno-array-bounds -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_LIBM=1 -DHAVE_POPEN=1 -DHAVE_MKSTEMP=1 -DHAVE_FNMATCH=1 -D_REENTRANT -Iinclude -Isrc -fPIC -o src/loaders/emod_load.lo src/loaders/emod_load.c src/loaders/it_load.c: In function 'it_load': src/loaders/it_load.c:691:15: warning: iteration 108u invokes undefined behavior [-Waggressive-loop-optimizations] c = i1h.keys[25 + j * 2] - 1; -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9nlpY5Gq1T&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review