https://bugzilla.redhat.com/show_bug.cgi?id=915864 --- Comment #17 from Steven Dake <sdake@xxxxxxxxxx> --- rm -rf %{buildroot} is not needed, please remove it. Also remove the other rm -rf commands in the script that are removing stuff in the buildroot. These are cause of concern in later packaging efforts. rpmlint warnings are out of control. Please fix the dangling symlinks, I believe that can result in a security issue - but am not certain. postun javadoc should not be removing files. Let the javadoc files be managed by the package manager, and rpm will remove them. files in confdir (/etc) need a confdir directive so they can be upgraded properly - otherwise the old configuration will be totally wiped out on an upgrade. Not sure what the class path in manifest warning is, but I don't think JARs should be in /usr/share (but I could be wrong). Ideally I would like to see the rpmlint warnings counts at zero, unless there is something broken about rpmlint. While brokeneness in rpmlint does happen (and gives false negatives) it is ideal that we don't have 480 rpmlint warnings in the package. Looking much better though, almost there :) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7aPFoAJbEP&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review