Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command Alias: ntop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025 ------- Additional Comments From pertusus@xxxxxxx 2007-03-10 19:03 EST ------- The patches look sane except that ntop-config.patch and ntop-conf.patch seems to patch the same file one after another. And moreover those patches seems to be unuseful since you overwrite the file? I suggest using the 'official scriptlets' found here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets Yours don't seem wrong, it is for consistency. Using /sbin/service may be more robust over time, however. It adds a Requires(preun): /sbin/service Build log looks saner, but there is still a duplication of the CFLAGS. In my opinion it comes from Makefile.am, the following line should be removed (at least @CFLAGS@ should be removed): AM_CFLAGS = @CFLAGS@ In the init file, maybe add the LSB bits? (within BEGIN INIT INFO) still in the init file the summary is a bit terse. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review