https://bugzilla.redhat.com/show_bug.cgi?id=968339 Greg Bailey <gbailey@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |gbailey@xxxxxxxxx --- Comment #3 from Greg Bailey <gbailey@xxxxxxxxx> --- Hi Jaromir, A couple of quick notes before doing the formal review: Regarding github references: http://fedoraproject.org/wiki/Packaging:SourceURL#Github I'd suggest defining the git commit as a %global instead of hardcoding it in the Source0 URL, so you'd have: %global commit 961ff24c805a474080520403409872b04e18f4d9 Source0: https://raw.github.com/pixelb/scripts/%{commit}/scripts/ps_mem.py The "ps_mem.py" script defines its own short description: line 175: help_msg = 'ps_mem.py - Show process memory usage\n'\ So, you may consider changing your summary line to: Summary: Show process memory usage but your summary of "Memory profiling tool" is OK too if that's what you prefer. You should add an empty "%build" section; the fedora-review tool seems to fail without it. It's a good idea to preserve timestamps when copying the files around. http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps I'd use: cp -p %{SOURCE0} %{name} cp -p %{SOURCE1} LICENSE -and- install -D -p -m755 %{name} %{buildroot}%{_bindir}/%{name} (You might want to re-retrieve your sources using the suggested tools in the above URL; your source RPM includes ps_mem.py with a timestamp in 2011, which is too old for the newest version 3.1. It should be approx. May 10, 2013) For building against EPEL 5, could you add the following? (see: fedoraproject.org/wiki/EPEL:Packaging ) BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) %install rm -rf %{buildroot} install -D -p -m755 %{name} %{buildroot}%{_bindir}/%{name} -and- %clean rm -rf %{buildroot} If you'd prefer me to just attach my spec file, let me know. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DSwZ0e5oCp&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review