https://bugzilla.redhat.com/show_bug.cgi?id=961907 Josef Stribny <jstribny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Josef Stribny <jstribny@xxxxxxxxxx> --- Hi, thank you for looking into it. Running two koji builds without any tests or specs is a bit pointless in this case. It doesn't confirm if this is working or not and I had a valid concern since it fails on travis, where the specs are running. I am including the failed spec here: ``` Failures: 1) Moped::Connection::Pool#checkout when connections exist in the pool when a connection exists for another thread id when the pool is saturated when reaping does not free any new connections raises an error Failure/Error: expect { expected Moped::Errors::ConnectionInUse but nothing was raised # ./spec/moped/connection/pool_spec.rb:196:in `block (7 levels) in <top (required)>' Finished in 16.59 seconds 513 examples, 1 failure, 4 pending ``` Note: it might not be an issue for 1.5.0. This seems to be only a little issue though and I can't tell if it's lib or spec that needs to be patched. You could probably file it for upstream if it's not already and clarify that. But I agree that we don't need to ship the specs in this case. The other fixes in the spec file are good, SRPM builds & installs, rpmlint doesn't complain --> APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qb2RTlWqDR&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review