https://bugzilla.redhat.com/show_bug.cgi?id=963670 --- Comment #3 from Dan Horák <dan@xxxxxxxx> --- (In reply to Karsten Hopp from comment #2) > [MUST] the explicit-lib-dependency needs to be fixed > [SHOULD] as this package contains a shared library, ldconfig should probably > be run in %post and %postun the library is built in the so-called vendor mode, which makes it actually a plugin that's dlopen()-ed by the user library (libhbaapi), so using Requires: libhbaapi automatically installs also the user library when this plugin is installed, also meaning ldconfig calls are not necessary. I should even remove the plugin's soname from Provides. > [SHOULD] add a 'Provides: s390utils-libzfcphbaapi' to libzfcphbaapi > [SHOULD] add a 'Provides: s390utils-libzfcphbaapi-docs' to libzfcphbaapi-docs makes sense, will add > [SHOULD] The 'shared-lib-calls-exit' warning looks suspicious, and needs to > be looked at. will be brought to upstream > [MUST] The spec file doesn't consistently use macros vs. variables. > $RPM_BUILD_ROOT should be replaced by %{buildroot} > $RPM_OPT_FLAGS should be replaced by %{optflags} by inconsistency the guideline means that one shouldn't mix $RPM_BUILD_ROOT with %{buildroot} in one spec file which I don't -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z6aVoos3Ae&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review