https://bugzilla.redhat.com/show_bug.cgi?id=964161 Kalev Lember <kalevlember@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #7 from Kalev Lember <kalevlember@xxxxxxxxx> --- Fedora review libpng15-1.5.13-3.fc18.src.rpm 2013-05-29 $ rpmlint libpng15-1.5.13-3.fc20.src.rpm \ libpng15-1.5.13-3.fc20.x86_64.rpm \ libpng15-debuginfo-1.5.13-3.fc20.x86_64.rpm libpng15.src: W: spelling-error Summary(en_US) libpng -> sibling libpng15.src: W: spelling-error %description -l en_US libpng -> sibling libpng15.src: E: specfile-error warning: bogus date in %changelog: Thu Jul 28 2000 Preston Brown <pbrown@xxxxxxxxxx> libpng15.x86_64: W: spelling-error Summary(en_US) libpng -> sibling libpng15.x86_64: W: spelling-error %description -l en_US libpng -> sibling libpng15.x86_64: W: incoherent-version-in-changelog 2:1.5.13-3 ['1.5.13-3.fc20', '1.5.13-3'] 3 packages and 0 specfiles checked; 1 errors, 5 warnings. + OK ! needs attention + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The package contains the license file (LICENSE) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 186b3098d1ef844f76681bc69968efe2 libpng-1.5.13.tar.bz2 186b3098d1ef844f76681bc69968efe2 Download/libpng-1.5.13.tar.bz2 + The package builds in koji (F20) n/a ExcludeArch bugs filed + BuildRequires look sane n/a Proper locale handling + ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Remaining issues: o rpmlint warnings: incoherent-version-in-changelog and bogus date in %changelog -- should be easy to fix up to make rpmlint happier o source URL: I had to locally fix it up to verify the sources, would be great if you could do it in the package file as well - Source0: ftp://ftp.simplesystems.org/pub/png/src/libpng-%{version}.tar.bz2 + Source0: ftp://ftp.simplesystems.org/pub/png/src/history/libpng15/libpng-%{version}.tar.bz2 Otherwise looks good. No need to post new spec files here, just fix these two minor issues up on your own before importing the package. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nyqxppZEoL&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review