https://bugzilla.redhat.com/show_bug.cgi?id=962029 --- Comment #6 from Wolfgang Ulbrich <chat-to-me@xxxxxxxxx> --- (In reply to Eduardo Echeverria from comment #5) > > ------------------------------------------------------------------------ > > GPL (v2 or later) > > ----------------- > > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > > libdbusmenu-12.10.2/ltmain.sh > > /var/lib/mock/fedora-19-x86_64/root/builddir/build/BUILD/libdbusmenu-12.10.2/ > > libdbusmenu-gtk3-12.10.2/ltmain.sh > This files (ltmain.sh) are part of Gnu Libtool, them have an exception, > > i quote > > "As a special exception to the GNU General Public License, > if you distribute this file as part of a program or library that > is built using GNU Libtool, you may include this file under the > same distribution terms that you use for the rest of that program." > > therefore the application is not GPLv2+ Ok, i agree. > > > > 2. > > [!]: Package does not own files or directories owned by other packages. > > > > %dir %{_libdir}/girepository-1.0/ > > Your package owns the whole folder in -main, -gtk2 and -gtk3 package. But it > > is already owned by gobject-introspection. Please remove those lines. > > > Fixed in 2 You forget to do this for the -gtk2 subpackage, anyway you can do this before uploading to git. > > > 3. > > Pls add Requires: %{name} = %{version}-%{release} to -doc subpackage, > > otherwise it's possible to install the doc package without the main package. > > Don't use the the isa tag here, this will cause an install error. > > > It is usually not desirable for documentation packages to depend on the main > packages, because users may want to install the docs before they decide > whether they want to install the package. Ok, i agree, results comming soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d4ED3qGyGY&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review