https://bugzilla.redhat.com/show_bug.cgi?id=915864 --- Comment #9 from Steven Dake <sdake@xxxxxxxxxx> --- Jimmy, The file oat-1.6.0-pregen-xsd.patch looks troubling. What creates this file? If upstream version changes, how is it recreated? Pregeneration of code should happen in the %build section, not in a patch from a tool outside of Fedora packaging. If tools are used to generate patches (rather then humans) that don't have approved Fedora licenses and have gone through the fedora packaging process, it is possible they could be in violation of our guidelines (ie not have an acceptable license, etc) or be abandoned. This would leave the future maintainer of the oats package in a serious bind. Please find a mechanism to build this at build time or convince me otherwise. jetty-osgi has been broken into separate subpackages in rawhide. I am not sure which one the package requires. This needs fixing before I can continue the review. For the list of jetty-osgi-* packages, see: http://koji.fedoraproject.org/koji/buildinfo?buildID=421207 I attempted a koji build after taking out jetty-osgi as a dep and got an error: [sdake@bigiron SRPMS]$ koji build --scratch rawhide oat-1.6.0-2.fc18.src.rpm Uploading srpm: oat-1.6.0-2.fc18.src.rpm [====================================] 100% 00:02:50 5.23 MiB 31.34 KiB/sec Created task: 5435684 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5435684 Watching tasks (this may be safely interrupted)... 5435684 build (rawhide, oat-1.6.0-2.fc18.src.rpm): free 5435684 build (rawhide, oat-1.6.0-2.fc18.src.rpm): free -> open (arm02-builder09.arm.fedoraproject.org) 5435687 buildArch (oat-1.6.0-2.fc18.src.rpm, i686): open (buildvm-20.phx2.fedoraproject.org) 5435686 buildArch (oat-1.6.0-2.fc18.src.rpm, x86_64): open (buildvm-21.phx2.fedoraproject.org) 5435686 buildArch (oat-1.6.0-2.fc18.src.rpm, x86_64): open (buildvm-21.phx2.fedoraproject.org) -> FAILED: BuildError: error building package (arch x86_64), mock exited with status 1; see build.log for more information 0 free 2 open 0 done 1 failed 5435687 buildArch (oat-1.6.0-2.fc18.src.rpm, i686): open (buildvm-20.phx2.fedoraproject.org) -> FAILED: BuildError: error building package (arch i686), mock exited with status 1; see build.log for more information 0 free 1 open 0 done 2 failed 5435684 build (rawhide, oat-1.6.0-2.fc18.src.rpm): open (arm02-builder09.arm.fedoraproject.org) -> FAILED: BuildError: error building package (arch x86_64), mock exited with status 1; see build.log for more information 0 free 0 open 0 done 3 failed 5435684 build (rawhide, oat-1.6.0-2.fc18.src.rpm) failed [sdake@bigiron SRPMS]$ Please make sure you can build the package in koji against rawhide. The error is shown in the build log: [javac] Creating empty /builddir/build/BUILD/OpenAttestation-1.6.0/Source/HisWebServices/WEB-INF/classes/gov/niarl/sal/webservices/hisWebService/server/domain/package-info.class [jar] Building jar: /builddir/build/BUILD/OpenAttestation-1.6.0/Source/HisWebServices/HisWebServices.war BUILD FAILED /builddir/build/BUILD/OpenAttestation-1.6.0/Source/HisWebServices/build.xml:59: Problem creating jar: /builddir/build/BUILD/OpenAttestation-1.6.0/Source/HisWebServices/WEB-INF/lib/jaas.jar (No such file or directory) Total time: 2 seconds RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.vgbq35 (%build) Bad exit status from /var/tmp/rpm-tmp.vgbq35 (%build) This looks to me like perhaps you have some old files in your build environment that are allowing the build to work for you locally, but not koji remotely. Not certain on this point. Until these problems are solved, I won't be able to provide a review since I can't build the package. Also: [sdake@bigiron srpm]$ rpmlint oat*rpm oat.src: W: non-standard-group Cloud Infrastructure 1 packages and 0 specfiles checked; 0 errors, 1 warnings. BLOCKER: Note this should be the Applications/System like other cloud related technologies. For more about using koji see: https://fedoraproject.org/wiki/Using_the_Koji_build_system -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N0SzQGain9&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review